Ensure tests marked by memray run even if --memray is not passed
#57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaborbernat
reviewed
Nov 30, 2022
We need to fix the flaky test. Is passing now |
gaborbernat
requested changes
Nov 30, 2022
There was a problem hiding this comment.
Needs a news entry here https://github.com/bloomberg/pytest-memray/tree/main/docs/news
The fact that the plugin is not registered if `--memray` is not provided has proven to be a source of confusion and provides a bad UX. Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
pablogsal
force-pushed
the
run_without_command_line
branch
from
81357c2
to
ced5f88
Compare
gaborbernat
approved these changes
Dec 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fact that the plugin is not registered if
--memrayis notprovided has proven to be a source of confusion and provides a bad
UX.
Closes: #49