Fix long test names with xdist #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that we can successfully use `pytest-xdist` in conjunction with parametrized test functions with long names. This test fails as of this commit, but passes once the next commit is applied. Signed-off-by: Matt Wozniski <mwozniski@bloomberg.net>
When `pytest-xdist` is in use and `--memray-bin-path` isn't set, we need to keep a temporary directory around even after each individual distributed worker has completed. In this case, though, we don't need to name our capture files based on the name of the test, since the user didn't ask us to retain the capture files and so won't need to look at them. This lets us use names of our own choosing, rather than names derived from the test name, skirting filesystem limits on file name length. Signed-off-by: Matt Wozniski <mwozniski@bloomberg.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the
OSErrorcaused by long capture file names in our temporary directory when--memray-bin-pathis not in use bypytest-xdistis.Relates-to: #68