Relax the sizes in the 'test_limit_memory_marker_with_pytest_xdist' test #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using `pytest-xdist` there are some extra allocations that the
plugin does that make it quite difficult to test values for the `limit`
decorator that are close to the numeric limit. In particular this is a
sample list of allocations in Python 3.11 when the plugin is active:
```
List of allocations:
- 628.0B allocated here:
channel_data:/lib/python3.11/site-packages/execnet/gateway_base.py:476
- 534.0B allocated here:
_local_receive:/lib/python3.11/site-packages/execnet/gateway_base.py:856
- 772.0B allocated here:
handle_command:/lib/python3.11/site-packages/xdist/remote.py:128
- 1.0KiB allocated here:
valloc:/lib/python3.11/site-packages/memray/_test.py:44
- 862.0B allocated here:
_thread_receiver:/lib/python3.11/site-packages/execnet/gateway_base.py:969
```
The only one the test cares about is the one made using `valloc`, but
unlike in the `memray` test suite we cannot filter them in the tests, so
we need to make the allocation sizes bigger and remove the tests that
are checking exactly in the limit.
lkollar
approved these changes
Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
pytest-xdistthere are some extra allocations that theplugin does that make it quite difficult to test values for the
limitdecorator that are close to the numeric limit. In particular this is a
sample list of allocations in Python 3.11 when the plugin is active:
The only one the test cares about is the one made using
valloc, butunlike in the
memraytest suite we cannot filter them in the tests, sowe need to make the allocation sizes bigger and remove the tests that
are checking exactly in the limit.