Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new --fail-on-increase option #91

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Aug 23, 2023

As requested from some users, add a new --fail-on-increase option that
makes the test run fail if the memory usage increases from previous runs
in tests marked with "limit_memory".

*Issue number of the reported bug or feature request: #7

Describe your changes
A clear and concise description of the changes you have made.

Testing performed
Describe the testing you have performed to ensure that the bug has been addressed, or that the new feature works as planned.

Additional context
Add any other context about your contribution here.

closes: #7

README.md Outdated Show resolved Hide resolved
@pablogsal
Copy link
Member Author

@godlygeek can you review again?

As requested from some users, add a new --fail-on-increase option that
makes the test run fail if the memory usage increases from previous runs
in tests marked with "limit_memory".

Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
Copy link
Contributor

@godlygeek godlygeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though there was a small typo in the news entry which I corrected.

I've rebased this as well.

@godlygeek godlygeek merged commit 40e3601 into bloomberg:main Nov 7, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

compare memory usage between pytest runs
2 participants