Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update @bloomberg/record-tuple-polyfill in the playground #65

Merged

Conversation

nicolo-ribaudo
Copy link
Contributor

The playground does not support Box: if you try to import it from the polyfill you get an error: link. I think it's because the playground depends on version ^0.0.1 of the polyfill, which only matches 0.0.1 and not 0.0.3 (the last published version):
semver.npmjs.com screenshot showing that ^0.0.1 only matches 0.0.1
(you can verify it at https://semver.npmjs.com/)

Since the playground is a private package, it's safe to just depend on * so that it always uses the polyfill from the monorepo.

Signed-off-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>
@rickbutton
Copy link
Member

good find, I'll get a new build of the playground up shortly.

@rickbutton rickbutton merged commit b555307 into bloomberg:master Sep 16, 2021
@nicolo-ribaudo nicolo-ribaudo deleted the update-playground-polyfill branch September 16, 2021 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants