Add HTML side by side (diff) format #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #102 +/- ##
==========================================
+ Coverage 96.33% 96.43% +0.09%
==========================================
Files 47 49 +2
Lines 2400 2719 +319
==========================================
+ Hits 2312 2622 +310
- Misses 88 97 +9
Continue to review full report at Codecov.
|
Main feature: - Adding a new html format `htmlSideBySide` that displays results in a diff like format - This can sometimes be easier to read through, espically when comparing differences in common values Supporting changes: - HTML escpae utility was pulled out to its own extension to allow sharing between both html renderers - A small fix was made to the Makefil to enable regenerating tests TODO: - [ ] Iterate on styles, are there any better options? - [ ] Are there any alternate format names that are more suitable (e.g. `htmlDiff`)? Test Plan: - Generate a diff using the new side by side format and examine the results ```sh swift build LOCAL_XCDIFF=$(pwd)/.build/debug/xcdiff cd Fixtures $LOCAL_XCDIFF --format htmlSideBySide --verbose > results.html open results.html ``` Signed-off-by: Kassem Wridan <kwridan@bloomberg.net>
kwridan
force-pushed
the
feature/html-diff-side-by-side
branch
from
b5fab42
to
842753f
Compare
- Added grey background color for empty cells - Added a different yellow color for value mismatch keys - Removed "Value mismatch" label and replaced with a spacer Signed-off-by: Kassem Wridan <kwridan@bloomberg.net>
|
@marciniwanicki did you have any preferences on what to call the new format? is |
|
@kwridan no preference, I like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Main feature:
htmlSideBySidethat displays results in a diff like formatSupporting changes:
TODO:
htmlDiff)?Testing performed
Screenshots