-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HTML side by side (diff) format #102
Add HTML side by side (diff) format #102
Conversation
Codecov Report
@@ Coverage Diff @@
## main #102 +/- ##
==========================================
+ Coverage 96.33% 96.43% +0.09%
==========================================
Files 47 49 +2
Lines 2400 2719 +319
==========================================
+ Hits 2312 2622 +310
- Misses 88 97 +9
Continue to review full report at Codecov.
|
Main feature: - Adding a new html format `htmlSideBySide` that displays results in a diff like format - This can sometimes be easier to read through, espically when comparing differences in common values Supporting changes: - HTML escpae utility was pulled out to its own extension to allow sharing between both html renderers - A small fix was made to the Makefil to enable regenerating tests TODO: - [ ] Iterate on styles, are there any better options? - [ ] Are there any alternate format names that are more suitable (e.g. `htmlDiff`)? Test Plan: - Generate a diff using the new side by side format and examine the results ```sh swift build LOCAL_XCDIFF=$(pwd)/.build/debug/xcdiff cd Fixtures $LOCAL_XCDIFF --format htmlSideBySide --verbose > results.html open results.html ``` Signed-off-by: Kassem Wridan <kwridan@bloomberg.net>
b5fab42
to
842753f
Compare
- Added grey background color for empty cells - Added a different yellow color for value mismatch keys - Removed "Value mismatch" label and replaced with a spacer Signed-off-by: Kassem Wridan <kwridan@bloomberg.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great 👍
@marciniwanicki did you have any preferences on what to call the new format? is |
@kwridan no preference, I like |
Describe your changes
Main feature:
htmlSideBySide
that displays results in a diff like formatSupporting changes:
TODO:
htmlDiff
)?Testing performed
Screenshots