-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to use ArgumentParser #105
Update to use ArgumentParser #105
Conversation
74d37d8
to
6230cf0
Compare
Codecov Report
@@ Coverage Diff @@
## main #105 +/- ##
==========================================
+ Coverage 96.43% 96.54% +0.11%
==========================================
Files 49 49
Lines 2719 2636 -83
==========================================
- Hits 2622 2545 -77
+ Misses 97 91 -6
Continue to review full report at Codecov.
|
fbcf303
to
7c2bf37
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ntduyet , the changes look great👍 Noticed some lint errors, might be worth adjusting Xcode settings
.
Thanks @marciniwanicki, hope it gets fixed now. |
@ntduyet since we cannot use "Squash and merge", do you mind tiding up your branch history a little bit?
Once done, we can rebase and merge. I think the hash will still be different, but I hope we will end up with a nice git history on |
@marciniwanicki sure thing |
00cad88
00cad88
to
212b854
Compare
Describe your changes - Update to use ArgumentParser Testing performed - All unit tests are passed. Signed-off-by: Duyet Nguyen <duyet@bloomberg.net>
212b854
to
28cb3e2
Compare
Issue number of the reported bug or feature request: #94
Describe your changes
Testing performed