Fix brew install warning #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 96.69% // Head: 96.69% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #118 +/- ##
=======================================
Coverage 96.69% 96.69%
=======================================
Files 50 50
Lines 2750 2750
=======================================
Hits 2659 2659
Misses 91 91 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
marciniwanicki
force-pushed
the
mi/fix-brew-install-error
branch
2 times, most recently
from
5b88361
to
4631254
Compare
An error was printed when called `brew install swiftlint.rb`. It turned out brew has now `install --formula` parameter which allows to install from local formula file. ```bash ... Error: Failed to load cask: swiftlint.rb Cask 'swiftlint' is unreadable: wrong constant name #<Class:0x000000013f213780> Warning: Treating swiftlint.rb as a formula. ... ``` Test Plan: - Ensure all CI checks pass - Inspect CI logs, ensure no error or warning is reported Signed-off-by: Marcin Iwanicki <miwanicki1@bloomberg.net>
marciniwanicki
force-pushed
the
mi/fix-brew-install-error
branch
from
4631254
to
4baedea
Compare
kwridan
approved these changes
Nov 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
An error was printed when called
brew install swiftlint.rb. It turned out brew has nowinstall --formulaparameter which allows to install from local formula file.Testing performed