-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shorthand Optional Binding #125
Conversation
fa1bc75
to
bf077a7
Compare
Codecov ReportBase: 96.71% // Head: 96.71% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #125 +/- ##
=======================================
Coverage 96.71% 96.71%
=======================================
Files 50 50
Lines 2773 2773
=======================================
Hits 2682 2682
Misses 91 91
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for contributing this @avbangar
Can we trouble you to re-submit with a signed commit?
Some more details on why this is needed can be found here:
https://github.com/bloomberg/.github/blob/master/CONTRIBUTING.md#contribution-licensing
Signed-off-by: Aakash Bangar <aakash.bangar@aexp.com>
b6cb20c
to
6279ee0
Compare
Sure thing @kwridan! I'm not really sure why but my original commit message was signed with my alternative email address 🤔 I think it's fixed now though: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks for the updates!
Issue number of the reported bug or feature request: #124
Describe your changes:
Swift 5.7
.Example:
Can now be shortened to:
This also works for
guard let
,if var
, etc.Testing performed:
Ran the tests provided using
swift test
.