Bump Xcode version to 14.3.1 #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marciniwanicki
previously approved these changes
Oct 2, 2023
|
We might be hitting actions/runner-images#8341 |
kwridan
force-pushed
the
update/xcode-14-3-1
branch
from
08ad263
to
aa2690f
Compare
kwridan
force-pushed
the
update/xcode-14-3-1
branch
from
aa2690f
to
ad9aecb
Compare
- Bumped github workflow to build with macOS 13 images + Xcode 14.3.1 - Updated minimum OS to be 10.15 (as that is the minimum by some of the newer versions of the dependencies - e.g. SwiftToolsSupport) Test Plan: - Verify CI passes Signed-off-by: Kassem Wridan <kwridan@bloomberg.net>
kwridan
force-pushed
the
update/xcode-14-3-1
branch
from
ad9aecb
to
fd394e5
Compare
|
My mistake, there were 2 steps that needed an update with the runner 🤦♂️ |
marciniwanicki
approved these changes
Oct 2, 2023
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #127 +/- ##
==========================================
+ Coverage 96.71% 96.95% +0.24%
==========================================
Files 50 50
Lines 2773 2894 +121
==========================================
+ Hits 2682 2806 +124
+ Misses 91 88 -3 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Testing performed