Removed SPMUtility from XCDiffCore #27
Conversation
…nd relative path to base path. Signed-off-by: Todor Brachkov <tbrachkov@gmail.com>
Signed-off-by: Todor Brachkov <tbrachkov@gmail.com>
Signed-off-by: Todor Brachkov <tbrachkov@gmail.com>
Signed-off-by: Todor Brachkov <tbrachkov@gmail.com>
There was a problem hiding this comment.
Many thanks @tbrachkov, the PR looks great! I am super excited - dropping a dependency is always an achievement! Left few very minor comments / questions.
| delimiter = "::" | ||
| } | ||
|
|
||
| func test_split_empty_string() { |
There was a problem hiding this comment.
We have very informal, but commonly used pattern for naming the tests:
test<method_name>_[when]<condition>_[<expected_result>]
whenis optionalexpected resultis also optional
i.e.
testSplit_whenStringNotContainDelimiter
There was a problem hiding this comment.
I like the style guide, renamed the test functions.
| equal(testString.split(around: delimiter), ("foo", "bar")) | ||
| } | ||
|
|
||
| func equal(_ lhs: (String, String?), _ rhs: (String, String?), file: StaticString = #file, line: UInt = #line) { |
There was a problem hiding this comment.
Nice matcher! Maybe we can add private and rename to highlight it asserts? i.e. assertEqual ?
We can also replace lhs by actual and rhs by expected.
and lastly.. we usually add
// MARK: - Private
above the private section :)
There was a problem hiding this comment.
I am not sure what could be the implication of those methods not being private? I have made all of the helpers private and marked as private.
There was a problem hiding this comment.
It's very minor. We usually try to limit the visibility of types, properties, methods to bare minimum in both production and test code. In general, it makes it easier to reason about the code (and hopefully helps the compiler a little bit as well) , but agree, in this specific case it's more for consistency than anything else :)
• Updated helper functions in tests to be marked as private. • Renamed test functions to match the style guide. • Extended test for edge cases on the relative path tests. Signed-off-by: Todor Brachkov <tbrachkov@gmail.com>
Issue number of the reported bug or feature request: #26
Describe your changes
Removed the
SPMUtilityfromXCDiffCore. Added replacement forsmp_splitand relative path to base path.Testing performed
Added unit test for the new helpers.
Additional context
By removing
SPMUtilityfromXCDiffCorenow we can enableCocoaPodsforXCDiffCore.Signed-off-by: Todor Brachkov tbrachkov@gmail.com