Fix SettingsComparator to handle missing configurations #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcin Iwanicki <miwanicki1@bloomberg.net>
marciniwanicki
force-pushed
the
feature/fix-settings-comparator-when-missing-configuration
branch
from
df0f37c
to
88c8d73
Compare
marciniwanicki
deleted the
feature/fix-settings-comparator-when-missing-configuration
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
For some projects,
SettingsComparatorcan return enigmatic error messages "ERROR: Configuration not found". We didn't expect to the targets to contain an emptyXCConfigurationListbut it looks, it's a valid scenario.Update the logic so an empty list is handled in the same way as missing
XCConfigurationList. When one of the targets has a valid configuration object, but the second does not have configuration or has an empty configuration list, "only in..." error will be triggered.Testing performed
CI