Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup codecov #36

Merged

Conversation

marciniwanicki
Copy link
Contributor

@marciniwanicki marciniwanicki commented Dec 10, 2019

Describe your changes
Set up codecov.io to make the code coverage data more visible for the contributors.

Testing performed
I was primarily testing the integration locally and via this PR.

Additional context
Thanks @kwridan for pushing back on xcodebuild. Using swift test is a way better option. Glad I've found @wnagrodzki 's comment (https://community.codecov.io/t/swift-package-support/675)

@codecov
Copy link

codecov bot commented Dec 10, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@64e4693). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #36   +/-   ##
=========================================
  Coverage          ?   94.82%           
=========================================
  Files             ?       39           
  Lines             ?     1663           
  Branches          ?        0           
=========================================
  Hits              ?     1577           
  Misses            ?       86           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64e4693...b3dfbdd. Read the comment docs.

@marciniwanicki marciniwanicki changed the title [WIP] Setup codecov Setup codecov Dec 10, 2019
@marciniwanicki marciniwanicki force-pushed the feature/setup-codecov branch 2 times, most recently from 34561c9 to 44cc7f0 Compare December 10, 2019 23:36
Signed-off-by: Marcin Iwanicki <miwanicki1@bloomberg.net>
Copy link
Contributor

@kwridan kwridan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@marciniwanicki marciniwanicki merged commit e000640 into bloomberg:master Dec 11, 2019
@marciniwanicki marciniwanicki deleted the feature/setup-codecov branch December 11, 2019 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants