Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display values for settings present only in one project #54

Conversation

marciniwanicki
Copy link
Contributor

Resolves: #51

Describe your changes
Extended the output of settings and resolved_settings comparators to include setting values.

Testing performed

  • CI
  • Go to Fixtures and run xcdiff -g settings -t Project -v, ensure setting values are displayed in "Only in..." sections, i.e.
⚠️  Only in second (1):

  • CUSTOM_SETTGING_1 = CS_1_PROJECT_LEVEL

Signed-off-by: Marcin Iwanicki <miwanicki1@bloomberg.net>
@codecov
Copy link

codecov bot commented May 23, 2020

Codecov Report

Merging #54 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #54   +/-   ##
=======================================
  Coverage   95.76%   95.77%           
=======================================
  Files          43       43           
  Lines        1465     1467    +2     
=======================================
+ Hits         1403     1405    +2     
  Misses         62       62           
Impacted Files Coverage Δ
Sources/XCDiffCore/Library/SettingsHelper.swift 94.87% <100.00%> (+0.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95f413a...9cdbbb1. Read the comment docs.

Copy link
Contributor

@kwridan kwridan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@marciniwanicki marciniwanicki merged commit fb184a6 into bloomberg:master May 28, 2020
@marciniwanicki marciniwanicki deleted the feature/51-settings-current-value branch May 28, 2020 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Settings that appear in only one of the projects should inform their current value
2 participants