Extend --list command output to show which comparators do not run by default #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #55 +/- ##
==========================================
+ Coverage 95.77% 95.82% +0.05%
==========================================
Files 43 43
Lines 1467 1486 +19
==========================================
+ Hits 1405 1424 +19
Misses 62 62
Continue to review full report at Codecov.
|
kwridan
previously approved these changes
May 26, 2020
| - RESOLVED_SETTINGS | ||
| - SOURCE_TREES | ||
| - LINKED_DEPENDENCIES | ||
| COMPARTOR TAG | DEFAULT |
There was a problem hiding this comment.
I wonder if the wording needs a slight tweak or possibly additional text is needed?
e.g. It may not be obvious what Default means in this context?
Some ideas:
COMPARTOR TAG | INCLUDED BY DEFAULT
------------------------------------------------------
- FILE_REFERENCES | Yes
- BUILD_PHASES | Yes
- COPY_FILES | Yes
- TARGETS | Yes
- HEADERS | Yes
- SOURCES | Yes
- RESOURCES | Yes
- CONFIGURATIONS | Yes
- SETTINGS | Yes
- RESOLVED_SETTINGS | No
- SOURCE_TREES | Yes
- LINKED_DEPENDENCIES | Yes
It's a bit too long
The following list shows all available comparator tags along with their default inclusion status when tags aren't explicitly specified.
COMPARTOR TAG | INCLUDED
------------------------------------------------------
- FILE_REFERENCES | Yes
- BUILD_PHASES | Yes
- COPY_FILES | Yes
- TARGETS | Yes
- HEADERS | Yes
- SOURCES | Yes
- RESOURCES | Yes
- CONFIGURATIONS | Yes
- SETTINGS | Yes
- RESOLVED_SETTINGS | No
- SOURCE_TREES | Yes
- LINKED_DEPENDENCIES | Yes
There was a problem hiding this comment.
Thanks @kwridan, good idea. I went for the 2nd option
marciniwanicki
force-pushed
the
feature/49-list-with-defaults
branch
from
a563d77
to
3b4c37f
Compare
kwridan
previously approved these changes
May 29, 2020
… default Signed-off-by: Marcin Iwanicki <miwanicki1@bloomberg.net>
Signed-off-by: Marcin Iwanicki <miwanicki1@bloomberg.net>
marciniwanicki
force-pushed
the
feature/49-list-with-defaults
branch
from
3b4c37f
to
a7ad82c
Compare
|
👋 @kwridan, I had to rebase, we will need one more re-✅. |
kwridan
approved these changes
May 30, 2020
|
Thank you : -) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #49
Testing performed
xcdiff --list, ensure all exceptRESOLVED_SETTINGScomparators are listed with default valueYes.