Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Xcode12 and MacOS 10.15 for CI #67

Merged
merged 1 commit into from
Oct 13, 2020

Conversation

marciniwanicki
Copy link
Contributor

@marciniwanicki marciniwanicki commented Oct 1, 2020

  • Updated CI image to use Xcode12
  • Updated brew.sh script as the brew installation from URL does not work in the latest brew version. Likely @kwridan idea of using local<formula>.rb file works. It struggles with longer relative paths (i.e. brew install Scripts/Formulas/swiftlint.rb - I guess the path is treated as a tap/cask identifier), but works well if called with just filename (brew install swiftlint.rb).
  • It looks the new macOS image comes with a preinstalled version of SwiftLint, tweaked the script to enforce using the version from the local formula.

Test Plan:

  • CI

@codecov
Copy link

codecov bot commented Oct 1, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@243cae5). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #67   +/-   ##
=========================================
  Coverage          ?   96.17%           
=========================================
  Files             ?       44           
  Lines             ?     1672           
  Branches          ?        0           
=========================================
  Hits              ?     1608           
  Misses            ?       64           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 243cae5...809be89. Read the comment docs.

Signed-off-by: Marcin Iwanicki <miwanicki1@bloomberg.net>
@marciniwanicki marciniwanicki marked this pull request as ready for review October 6, 2020 19:56
@marciniwanicki marciniwanicki merged commit c696714 into bloomberg:master Oct 13, 2020
@marciniwanicki marciniwanicki deleted the feature/xcode12 branch October 13, 2020 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants