Add Swift Package comparator #74
Conversation
kwridan
force-pushed
the
feature/swift-packages
branch
from
722ba1d
to
799c07d
Compare
| • ComposableArchitecture package reference | ||
| ◦ version = .upToNextMajorVersion(0.9.0) | ||
| ◦ version = .upToNextMinorVersion(0.9.0) |
There was a problem hiding this comment.
There is potentially some redundancy here as the same information can be seen within SWIFT_PACKAGES section. The reason I opted for adding it is to cater for the scenario where a package product doesn't have a source package specified (e.g. like the Swifter example below) and that can only be highlighted here as it's a difference at the linked dependency level.
| def substitute_project_paths(arg): | ||
| dirname = os.path.dirname(sys.argv[0]) | ||
| fixtures_path = os.path.join(dirname, "../Fixtures") | ||
| return re.sub("{(.*)}", "{}/\\1/Project.xcodeproj".format(fixtures_path), arg) |
There was a problem hiding this comment.
this should allow us to add new fixtures without needing to modify the python script each time
Codecov Report
@@ Coverage Diff @@
## main #74 +/- ##
==========================================
- Coverage 96.21% 96.13% -0.09%
==========================================
Files 45 47 +2
Lines 1718 1809 +91
==========================================
+ Hits 1653 1739 +86
- Misses 65 70 +5
Continue to review full report at Codecov.
|
kwridan
force-pushed
the
feature/swift-packages
branch
from
799c07d
to
f23a52e
Compare
|
:-) sure, feel free to update the threshold or add a simple UT for |
| import XCTest | ||
|
|
||
| final class SwiftPackageDescriptorTests: XCTestCase { | ||
| // swiftlint:disable line_length |
There was a problem hiding this comment.
Maybe we can re-enable the rule in the end of the tests (// swiftlint:enable line_length), or break the lines?
kwridan
force-pushed
the
feature/swift-packages
branch
2 times, most recently
from
729e2b8
to
b23f5fe
Compare
- Added a new comparator to check for Swift Package differences - Additionally, the linked dependencies comparator has been updated to accomodate package products references Test Plan - Run `swift run xcdiff -v` within `Fixtures/ios_project_with_swift_packages` - Verify the results include Swift Package comparison results Signed-off-by: Kassem Wridan <kwridan@bloomberg.net>
kwridan
force-pushed
the
feature/swift-packages
branch
from
b23f5fe
to
d28897b
Compare
Issue number of the reported bug or feature request: #24
Describe your changes
Testing performed
swift run xcdiff -vwithinFixtures/ios_project_with_swift_packages