Allow to decrease the coverage by up to 0.5% #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #75 +/- ##
=======================================
Coverage 96.21% 96.21%
=======================================
Files 45 45
Lines 1718 1718
=======================================
Hits 1653 1653
Misses 65 65 Continue to review full report at Codecov.
|
marciniwanicki
force-pushed
the
feature/add-codecov-config-file
branch
6 times, most recently
from
c73f793
to
25c2e5f
Compare
Signed-off-by: Marcin Iwanicki <miwanicki1@bloomberg.net>
marciniwanicki
force-pushed
the
feature/add-codecov-config-file
branch
from
4f61cf2
to
e7790a9
Compare
kwridan
approved these changes
Jan 15, 2021
There was a problem hiding this comment.
Thanks @marciniwanicki
0.5% might be still too strict, perhaps 1-2 %?
We can try to see how this fairs and revisit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Making all code contributions with nearly 100% coverage is not always worth the effort as such we want to introduce a little margin. We've added a custom codecov config file (
.codecov.yml) to pass PR checks if project regresses by less than 0.5% and the coverage of the changes is within 5% threshold compare to the coverage of the main branch.