Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings in CommandBasedTests #76

Conversation

marciniwanicki
Copy link
Contributor

Describe your changes

  • Fix the warnings in CommandBasedTests while building on macOS 10.15.
warning: 'scanString(_:into:)' was deprecated in macOS 10.15
        guard scanString(string, into: result) else {
              ^
warning: 'scanUpToCharacters(from:into:)' was deprecated in macOS 10.15
        guard scanUpToCharacters(from: characterSet, into: result) else {
              ^
warning: 'scanUpToCharacters(from:into:)' was deprecated in macOS 10.15
        guard scanUpToCharacters(from: characterSet, into: result) else {
              ^
warning: 'scanUpTo(_:into:)' was deprecated in macOS 10.15
        guard scanUpTo(string, into: result) else {
              ^
warning: 'scanInt32' was deprecated in macOS 10.15
        guard scanInt32(result) else {
  • Removed scanCharactersOrFail method as it was not used

Testing performed

  • Inspect the build output to verify there is no warnings

Signed-off-by: Marcin Iwanicki <miwanicki1@bloomberg.net>
@marciniwanicki marciniwanicki force-pushed the feature/fix-warnings-in-CommandBasedTests branch from b0e68fe to 453cd8a Compare January 16, 2021 13:06
@codecov
Copy link

codecov bot commented Jan 16, 2021

Codecov Report

Merging #76 (2ea3b99) into main (7a1e8a9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #76   +/-   ##
=======================================
  Coverage   96.13%   96.13%           
=======================================
  Files          47       47           
  Lines        1809     1809           
=======================================
  Hits         1739     1739           
  Misses         70       70           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a1e8a9...2ea3b99. Read the comment docs.

@marciniwanicki marciniwanicki marked this pull request as ready for review January 18, 2021 19:14
@marciniwanicki marciniwanicki merged commit addd7bf into bloomberg:main Jan 21, 2021
@marciniwanicki marciniwanicki deleted the feature/fix-warnings-in-CommandBasedTests branch January 21, 2021 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants