Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Static checksum comparision of codecov script. #80

Merged
merged 1 commit into from
May 8, 2021
Merged

Static checksum comparision of codecov script. #80

merged 1 commit into from
May 8, 2021

Conversation

kennethshackleton
Copy link
Member

@codecov
Copy link

codecov bot commented May 8, 2021 •
edited

Codecov Report

Merging #80 (9580042) into main (c4e97a8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #80   +/-   ##
=======================================
  Coverage   96.13%   96.13%           
=======================================
  Files          47       47           
  Lines        1809     1809           
=======================================
  Hits         1739     1739           
  Misses         70       70

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4e97a8...9580042. Read the comment docs.

@kennethshackleton kennethshackleton marked this pull request as ready for review May 8, 2021 09:52
@kennethshackleton
Static checksum comparision of codecov script.
9580042 
Signed-off-by: Kenneth J. Shackleton <kshackleton1@bloomberg.net>
marciniwanicki
marciniwanicki approved these changes May 8, 2021
View reviewed changes
Copy link
Contributor

@marciniwanicki marciniwanicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement! Thanks @kennethshackleton 🙌

@marciniwanicki marciniwanicki merged commit ee8ed3a into bloomberg:main May 8, 2021
@kennethshackleton kennethshackleton deleted the fixes/codecov-checksum branch May 8, 2021 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marciniwanicki marciniwanicki marciniwanicki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kennethshackleton @marciniwanicki