Fix commands test generator for Xcode 12.5+ #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will need a rebase once #90 lands to address CI failures |
Codecov Report
@@ Coverage Diff @@
## main #91 +/- ##
=======================================
Coverage 96.22% 96.22%
=======================================
Files 47 47
Lines 1853 1853
=======================================
Hits 1783 1783
Misses 70 70 Continue to review full report at Codecov.
|
marciniwanicki
previously approved these changes
Aug 9, 2021
Resolves: bloomberg#87 - As of Xcode 12.5 using `swift run xcdiff` along with the `-v` (verbose) option produces additional unwanted output - This is caused by `-v` now also being an option the `swift` command respect to produce verbose output - To mitigate this, we no longer invoke `xcdiff` via `swift run xcdiff`, but instead we invoke the binary directly via `$(swift build --show-bin-path)/xcdiff` after it has been built Test Plan: - Run `make regenerate_command_snapshots` - Verify it works when using Xcode12.5+ Signed-off-by: Kassem Wridan <kwridan@bloomberg.net>
kwridan
force-pushed
the
fix/command-test-generator
branch
from
fdc0e6f
to
b41bacf
Compare
marciniwanicki
approved these changes
Aug 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #87
Description
swift run xcdiffalong with the-v(verbose) option produces additional unwanted output-vnow also being an option theswiftcommand respect to produce verbose outputxcdiffviaswift run xcdiff, but instead we invoke the binary directly via$(swift build --show-bin-path)/xcdiffafter it has been builtTest Plan:
make regenerate_command_snapshots