Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Qt to 6.2 LTS #47

Closed
navnavnav opened this issue Jul 10, 2022 · 1 comment
Closed

Upgrade Qt to 6.2 LTS #47

navnavnav opened this issue Jul 10, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@navnavnav
Copy link
Member

Bloom is currently built and shipped with Qt 6.1.2 binaries. Standard support for this version has ended, and I've noticed some potential concurrency issues in this version (which may be false positives, not sure yet). These issues were apparently addressed, to some extent, in some recent changes that were merged into the 6.4 branch. I'm hoping these changes will make there way up to the 6.2 LTS.

Given that Bloom is using an outdated version, I intend to upgrade to 6.2 LTS. Ideally, I would like to do this after those changes have been merged into 6.2.

I will keep an eye on Qt releases and update this ticket when I know more.

@navnavnav navnavnav added the enhancement New feature or request label Jul 10, 2022
@navnavnav navnavnav self-assigned this Jul 10, 2022
@navnavnav
Copy link
Member Author

navnavnav commented Jul 13, 2022

This is done. The develop branch is now on Qt 6.2.4 LTS. Changes will be shipped with v0.11.0.

Building Qt from source on Ubuntu 16.04 was too painful. Looking at Bloom's download analytics, I can see that literally no one has selected 16.04 when downloading Bloom, so I've decided to move the building to an 18.04 VM. This means Bloom's distributed binary will no longer work on Ubuntu 16.04 (or Debian 9 ("Stretch")-based systems), from version 0.11.0. This made things a little easier for me, but still quite difficult, as Qt's binaries only support 20.04 and later. So I still had to build Qt from source, but with fewer dependencies to worry about.

As part of this work, I've also done the following:

  • Moved resources out of src/resources.xml and into the CMakeLists.txt files, using the qt_add_resource() CMake macro
  • Separated Insight resources from the other application resources. Insight resources are now defined in src/Inisght/CMakeLists.txt
  • Moved away from using DT_RPATH to specify dependency paths in Bloom's binary. We're now using DT_RUNPATH. I was sure I had tried this before, and it didn't work, but I can't remember why. It's working at the moment, but I may have to revert back if I find any issues.

@navnavnav navnavnav added this to the v0.11.0 milestone Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

1 participant