Remove S3 key check to allow full boto auth flow #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…methods including IAM roles
|
This would also resolve #71 |
|
Ran |
|
Merged. Thanks! |
VarunWachaspati
pushed a commit
to VarunWachaspati/s4cmd
that referenced
this pull request
Oct 10, 2020
Remove S3 key check to allow full boto auth flow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Boto has a rich set of search methods to attempt to locate credentials. Currently s4cmd doesn't allow authentication to even be attempted without the secret key and access key. This means that s4cmd can't be used with IAM roles.
Full boto auth search pattern can be found here