Skip to content
This repository has been archived by the owner on Jan 4, 2023. It is now read-only.

Add an About dialog box #73

Closed
djensen47 opened this issue Apr 20, 2019 · 3 comments · Fixed by #77
Closed

Add an About dialog box #73

djensen47 opened this issue Apr 20, 2019 · 3 comments · Fixed by #77
Labels
feature/accepted A feature that has been accepted to be worked on in the feature good first issue Good for newcomers help wanted Extra attention is needed

Comments

@djensen47
Copy link

djensen47 commented Apr 20, 2019

It would be great to have an an "About" item on the Help menu. The dialog box at the very least should have the version number of BloomRPC but you could also include the same information that VS Code has:

image

And a nice to have is to check to see if an update is available.


BTW, thank you for building BloomRPC, it's super helpful and works really well. Indispensable for gRPC development.

@fenos
Copy link
Contributor

fenos commented Apr 24, 2019

Hi @djensen47 I totally agree that can be a nice dialog box!

Unfortunately i don't have a windows machine available at the moment, not sure i can implement this any time soon.

Any help will be appreciated

@fenos fenos added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Apr 24, 2019
@djensen47
Copy link
Author

djensen47 commented Apr 24, 2019

Isn't this an Electron app? Isn't there a way to do a cross-platform dialog box?

I think something like this should be available for all platforms not just Windows.

I can probably take a look but it'll be a few weeks to months. 😕

@fenos
Copy link
Contributor

fenos commented May 1, 2019

@djensen47 Ah I see! I though it was specific to windows. Cool let's look into it

@fenos fenos added feature/accepted A feature that has been accepted to be worked on in the feature and removed enhancement New feature or request labels May 7, 2019
@fenos fenos closed this as completed in #77 May 16, 2019
@fenos fenos mentioned this issue May 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature/accepted A feature that has been accepted to be worked on in the feature good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants