Skip to content
This repository has been archived by the owner on Jan 4, 2023. It is now read-only.

Feature/non mac about #77

Merged
merged 3 commits into from
May 16, 2019
Merged

Conversation

jackielii
Copy link
Collaborator

fix #73
Screenshot_2019-05-13_22-59-25

@fenos
Copy link
Contributor

fenos commented May 15, 2019

This is really nice!

One small change before merging this would be to group the about files on it's on folder to keep things tidier.

I'm not too picky on a folder name but something like about - nativeUI or something logical 😄
other than that this is great.

Thank you!

@jackielii
Copy link
Collaborator Author

@fenos updated. I feel like my bundle of the assets for prod is very messy.

I'm only just learning the Electron ecosystem... Do you want to accept this PR first and we can refactor it later?

For future reference:

  1. use type script & react for rendering
  2. use webpack internal bundling for the icon image
  3. less branch for checking process.env.NODE_ENV or HOT

@fenos
Copy link
Contributor

fenos commented May 16, 2019

@jackielii Thanks!

Yes, i think for now it's pretty good and simple enough for future changes if needed

Well done!

@fenos fenos merged commit 5e409e9 into bloomrpc:master May 16, 2019
@fenos fenos mentioned this pull request May 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an About dialog box
2 participants