Skip to content

Commit

Permalink
Merge pull request #5 from blooper05/preparation-for-v1-release
Browse files Browse the repository at this point in the history
🔖 chore: Minor modifications in preparation for the v1 release
  • Loading branch information
blooper05 committed Jun 17, 2022
2 parents 6be2906 + 34c9c38 commit afe6f70
Show file tree
Hide file tree
Showing 5 changed files with 12 additions and 11 deletions.
2 changes: 1 addition & 1 deletion .markdownlint.yml
@@ -1,4 +1,4 @@
# refs. https://github.com/DavidAnson/markdownlint/blob/HEAD/schema/.markdownlint.yaml
# @see https://github.com/DavidAnson/markdownlint/blob/HEAD/schema/.markdownlint.yaml
---
default: true

Expand Down
1 change: 1 addition & 0 deletions .yamllint.yml
@@ -1,3 +1,4 @@
# @see https://github.com/adrienverge/yamllint/blob/HEAD/yamllint/conf/default.yaml
---
extends: default

Expand Down
2 changes: 1 addition & 1 deletion LICENSE
@@ -1,6 +1,6 @@
MIT License

Copyright (c) 2021 reviewdog developers
Copyright (c) 2022 blooper05

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
Expand Down
14 changes: 7 additions & 7 deletions README.md
@@ -1,11 +1,11 @@
# action-rails_best_practices

[![test](https://github.com/blooper05/action-rails_best_practices/workflows/test/badge.svg)](https://github.com/blooper05/action-rails_best_practices/actions?query=workflow%3Atest)
[![reviewdog](https://github.com/blooper05/action-rails_best_practices/workflows/reviewdog/badge.svg)](https://github.com/blooper05/action-rails_best_practices/actions?query=workflow%3Areviewdog)
[![depup](https://github.com/blooper05/action-rails_best_practices/workflows/depup/badge.svg)](https://github.com/blooper05/action-rails_best_practices/actions?query=workflow%3Adepup)
[![release](https://github.com/blooper05/action-rails_best_practices/workflows/release/badge.svg)](https://github.com/blooper05/action-rails_best_practices/actions?query=workflow%3Arelease)
[![GitHub release (latest SemVer)](https://img.shields.io/github/v/release/blooper05/action-rails_best_practices?logo=github&sort=semver)](https://github.com/blooper05/action-rails_best_practices/releases)
[![action-bumpr supported](https://img.shields.io/badge/bumpr-supported-ff69b4?logo=github&link=https://github.com/haya14busa/action-bumpr)](https://github.com/haya14busa/action-bumpr)
[![test](https://img.shields.io/github/workflow/status/blooper05/action-rails_best_practices/test?label=test&logo=github&style=flat-square)](https://github.com/blooper05/action-rails_best_practices/actions?query=workflow:test)
[![reviewdog](https://img.shields.io/github/workflow/status/blooper05/action-rails_best_practices/reviewdog?label=reviewdog&logo=github&style=flat-square)](https://github.com/blooper05/action-rails_best_practices/actions?query=workflow:reviewdog)
[![depup](https://img.shields.io/github/workflow/status/blooper05/action-rails_best_practices/depup?label=depup&logo=github&style=flat-square)](https://github.com/blooper05/action-rails_best_practices/actions?query=workflow:depup)
[![release](https://img.shields.io/github/workflow/status/blooper05/action-rails_best_practices/release?label=release&logo=github&style=flat-square)](https://github.com/blooper05/action-rails_best_practices/actions?query=workflow:release)
[![GitHub release (latest SemVer)](https://img.shields.io/github/v/release/blooper05/action-rails_best_practices?logo=github&sort=semver&style=flat-square)](https://github.com/blooper05/action-rails_best_practices/releases)
[![action-bumpr supported](https://img.shields.io/badge/bumpr-supported-ff69b4?logo=github&style=flat-square)](https://github.com/haya14busa/action-bumpr)

![github-pr-review demo](https://user-images.githubusercontent.com/5299525/171834705-b2517107-e616-4289-8ed9-4e160164701c.png)
![github-pr-check demo](https://user-images.githubusercontent.com/5299525/171834709-130da062-3518-4b28-9a1c-24b58fe686b4.png)
Expand Down Expand Up @@ -68,7 +68,7 @@ jobs:
name: runner / rails_best_practices
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
- uses: blooper05/action-rails_best_practices@v1
with:
github_token: ${{ secrets.github_token }}
Expand Down
4 changes: 2 additions & 2 deletions testdata/app/models/user.rb
@@ -1,5 +1,5 @@
# refs. https://github.com/flyerhzm/rails_best_practices/blob/HEAD/spec/rails_best_practices/reviews/default_scope_is_evil_review_spec.rb#L12-L14
# refs. https://github.com/flyerhzm/rails_best_practices/blob/HEAD/spec/rails_best_practices/reviews/protect_mass_assignment_review_spec.rb#L17-L18
# @see https://github.com/flyerhzm/rails_best_practices/blob/HEAD/spec/rails_best_practices/reviews/default_scope_is_evil_review_spec.rb#L12-L14
# @see https://github.com/flyerhzm/rails_best_practices/blob/HEAD/spec/rails_best_practices/reviews/protect_mass_assignment_review_spec.rb#L17-L18
class User < ActiveRecord::Base
default_scope -> { order('created_at desc') }
end

0 comments on commit afe6f70

Please sign in to comment.