Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: docker container support #4

Merged
merged 7 commits into from
Sep 26, 2023
Merged

feat: docker container support #4

merged 7 commits into from
Sep 26, 2023

Conversation

li-guohao
Copy link
Contributor

introduce

docker container support

  • add Dockerfile
  • add sql init file schema-mysql.sql

releated issue

@li-guohao
Copy link
Contributor Author

编译镜像前请先使用 package 进行打包

@xiaozzzi
Copy link
Contributor

非常感谢你提交的PR！这个PR非常有用！🤩💯
当然如果可以的话，请在根目录下创建docker/build文件夹来保存Dockerfile文件，防止文件挪动后清除你的提交记录。
如果能同时创建一个README.md来简要说明编译命令的话那就更好啦！当然现在也足够完美了！README 也可以交由我来补充。

@li-guohao
Copy link
Contributor Author

非常感谢你提交的PR！这个PR非常有用！🤩💯

当然如果可以的话，请在根目录下创建docker/build文件夹来保存Dockerfile文件，防止文件挪动后清除你的提交记录。

如果能同时创建一个README.md来简要说明编译命令的话那就更好啦！当然现在也足够完美了！README 也可以交由我来补充。

不用谢，好的，我稍后把文件移动下并补充个文档，就在对应的docker/build 目录里新建

@li-guohao li-guohao changed the title feat: docker container support [WIP] feat: docker container support Sep 26, 2023
@li-guohao
Copy link
Contributor Author

非常感谢你提交的PR！这个PR非常有用！🤩💯 当然如果可以的话，请在根目录下创建docker/build文件夹来保存Dockerfile文件，防止文件挪动后清除你的提交记录。 如果能同时创建一个README.md来简要说明编译命令的话那就更好啦！当然现在也足够完美了！README 也可以交由我来补充。

子目录名称如果是 build 的话会触发 .gitignore，建议可以换个名字或者不需要这个子目录

还有 不知道 blossom-editor 是否有 dockerhub账号？可以通过 GitHub Action 自动构建推送，这样也方便大家拉取镜像部署，不需要每次都自己构建，需要你配置好 当前仓库的 Actions Repository secrets ，这里需要配置两个，分别是 dockerhub用户名 DOCKER_HUB_USERNAME 和 dockerhub用户令牌 DOCKER_HUB_ACCESS_TOKEN

@li-guohao
optimize: backend dockerfile support
f6fdc05 
- move Dockerfile to dir blossom-backend
- add some content in blossom-backend readme doc
- fix schema-mysql.sql create table blossom_article_reference when exists.
@li-guohao li-guohao changed the title [WIP] feat: docker container support feat: docker container support Sep 26, 2023
@xiaozzzi xiaozzzi merged commit 0408cb0 into blossom-editor:dev Sep 26, 2023
@li-guohao li-guohao deleted the docker branch September 26, 2023 15:25
@li-guohao li-guohao mentioned this pull request Sep 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@li-guohao @xiaozzzi