This repository has been archived by the owner on Dec 1, 2022. It is now read-only.
Refactored daemon-scheduler environment and deployment structure. #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuedtran
reviewed
Mar 10, 2017
| @@ -282,7 +283,7 @@ func (suite *APITestSuite) TestDeleteEnvironmentMissingEnvironment() { | |||
| assert.Equal(suite.T(), http.StatusNotFound, responseRecorder.Code) | |||
| } | |||
|
|
|||
| func (suite *APITestSuite) assertSame(environment *types.Environment, environmentModel *models.Environment) { | |||
| func (suite *APITestSuite) assertSame(environment *environmenttypes.Environment, environmentModel *models.Environment) { | |||
There was a problem hiding this comment.
Shouldn't it be environmentTypes? camelCase?
There was a problem hiding this comment.
Yes for variables. No for packages. environmenttypes is a package, not a variable. You'll see we reference package names in all lowercase everywhere.
poojamaiya
approved these changes
Mar 13, 2017
| inProgressLock sync.RWMutex | ||
| id string | ||
| ctx context.Context | ||
| environmentService environment.EnvironmentService |
There was a problem hiding this comment.
Can we make this environmentSvc to keep it consistent with deploymentSvc declared below? Or vice versa (use ..Service for both).
There was a problem hiding this comment.
Yup, I'll rename deploymentSvc to deploymentService when I do the deployments refactor.
kylbarnes
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactored daemon-scheduler environment and deployment structure.
Implementation details
Testing
cd cluster-state-service; make; cd ../)cd cluster-state-service; make release; cd ../)cd daemon-scheduler; make; cd ../)cd daemon-scheduler; make release; cd ../)New tests cover the changes: no
Description for the changelog
Refactored daemon-scheduler environment and deployment structure.
Licensing
This contribution is under the terms of the Apache 2.0 License: Yes
Before merging