Clean up Gradle build scripts, move config to root project #287
Conversation
The new version of gradle fixes some issues with the new `plugins` directive. In particular, it's now possible to use it to activate plugins in subprojects that have already been declared in the root project.
| classpath 'com.diffplug.gradle.spotless:spotless:2.4.1' | ||
| dependencyManagement { | ||
| imports { | ||
| mavenBom 'com.amazonaws:aws-java-sdk-bom:1.11.215' |
There was a problem hiding this comment.
do we need both sdk version or is this so we don't have to refactor code that doesn't use v2 now?
There was a problem hiding this comment.
Yes, this is so that we don't have to refactor the parts of the dataservice that still depend on V1 now.
buildSrc/build.gradle
Outdated
| @@ -20,6 +22,7 @@ dependencies { | |||
| exclude group: 'com.github.jknack', module: 'handlebars' | |||
| } | |||
|
|
|||
| // We can't rely on the dependency-managed version of lombok here, so we have to hardcode it: | |||
There was a problem hiding this comment.
The buildSrc special project is built before the main project, and so it can't get any configuration from the main project. I'll update the comment to make that clearer.
| @@ -71,7 +44,7 @@ dependencies { | |||
| 'org.apache.logging.log4j:log4j-slf4j-impl:2.8.+', | |||
There was a problem hiding this comment.
can we move logging to dep management too? since there's no reason to use different versions across projects
There was a problem hiding this comment.
Agreed; I'll do that as part of the bigger logging cleanup to move to slf4j everywhere.
This moves as much of our repeated subproject configuration as makes
sense to the root project, and versions more of the most common
dependencies using the dependencyManagement section.
This also consolidates all plugin versions in the root project using the
plugins {} block, and only applies them in subprojects that need them.
This moves as much of our repeated subproject configuration as makes sense to the root project, and versions more of the most common dependencies using
dependencyManagementin the root project.This also consolidates all plugin versions in the root project using the
plugins {}block, and only applies them in subprojects that need them. In order to make use of this new syntax in more places, this also upgrades the Gradle version to 4.3 (release notes)Licensing
This contribution is under the terms of the Apache 2.0 License: Yes