Implement a proper bump allocator #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a proper thread-safe bump allocator to bh_alloc. The previous allocator is now moved to the `fuzz` sub-module. This work was inspired by a Reddit [conversation](https://www.reddit.com/r/rust/comments/9twam5/jemalloc_was_just_removed_from_the_standard/e902qnh/). I felt pretty bad that my poor fuzzy allocator got held up to demonstrate a general purpose bump allocator. :) Anyway, the only dicey bit here is the AtomicUsize. I haven't done any stress testing on an ARM machine, which should be done. x86 has stricter memory ordering, hiding bugs that only turn up under ARM. Signed-off-by: Brian L. Troutwine <brian@troutwine.us>
|
Thank you for working on this! I think there may be a bug in the alignment handling. It’s not the size that needs to be rounded up, is the addressed of the returned pointer. Although the size of Rust types is always a multiple of their alignment (to make arrays work), this is not necessarily the case of |
|
@SimonSapin hey, thanks for this. I put this together without a test plan and fully believe there are bugs in it. Would you mind opening an issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a proper thread-safe bump allocator to bh_alloc. The previous allocator is now moved to the
fuzzsub-module. This work was inspired by a Reddit conversation. I felt pretty bad that my poor fuzzy allocator got held up to demonstrate a general purpose bump allocator. :)Anyway, the only dicey bit here is the AtomicUsize. I haven't done any stress testing on an ARM machine, which should be done. x86 has stricter memory ordering, hiding bugs that only turn up under ARM.
Signed-off-by: Brian L. Troutwine brian@troutwine.us