Skip to content

Commit

Permalink
net/mlx: do not enforce RSS hash offload
Browse files Browse the repository at this point in the history
[ upstream commit 6db1fde ]

Rx RSS hash offload should be controlled by the user
and should not be enforced by RSS multi-queue Rx mode.

Fixes: 8b945a7 ("drivers/net: update Rx RSS hash offload capabilities")

Author: Andrew Rybchenko <arybchenko@solarflare.com>
Signed-off-by: Alexander Kozyrev <akozyrev@mellanox.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
  • Loading branch information
Alexander Kozyrev authored and bluca committed Nov 9, 2020
1 parent 08dcf50 commit 247f3ab
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 6 deletions.
3 changes: 0 additions & 3 deletions drivers/net/mlx4/mlx4.c
Original file line number Diff line number Diff line change
Expand Up @@ -252,9 +252,6 @@ mlx4_dev_configure(struct rte_eth_dev *dev)
struct rte_flow_error error;
int ret;

if (dev->data->dev_conf.rxmode.mq_mode & ETH_MQ_RX_RSS_FLAG)
dev->data->dev_conf.rxmode.offloads |= DEV_RX_OFFLOAD_RSS_HASH;

/* Prepare internal flow rules. */
ret = mlx4_flow_sync(priv, &error);
if (ret) {
Expand Down
3 changes: 0 additions & 3 deletions drivers/net/mlx5/mlx5_ethdev.c
Original file line number Diff line number Diff line change
Expand Up @@ -405,9 +405,6 @@ mlx5_dev_configure(struct rte_eth_dev *dev)
return -rte_errno;
}

if (dev->data->dev_conf.rxmode.mq_mode & ETH_MQ_RX_RSS_FLAG)
dev->data->dev_conf.rxmode.offloads |= DEV_RX_OFFLOAD_RSS_HASH;

memcpy(priv->rss_conf.rss_key,
use_app_rss_key ?
dev->data->dev_conf.rx_adv_conf.rss_conf.rss_key :
Expand Down

0 comments on commit 247f3ab

Please sign in to comment.