Skip to content

Commit

Permalink
net/dpaa: fix jumbo frame flag condition for MTU set
Browse files Browse the repository at this point in the history
[ upstream commit 1d57225 ]

The jumbo frame uses the 'RTE_ETHER_MAX_LEN' as boundary condition,
but the Ether overhead is larger than 18 when it supports VLAN tag.
That will cause the jumbo flag rx offload is wrong when MTU size is
'RTE_ETHER_MTU'.

This fix will change the boundary condition with 'RTE_ETHER_MTU' and
overhead, that perhaps impacts the cases of the jumbo frame related.

Fixes: 25f8541 ("net/dpaa: support jumbo frames")

Signed-off-by: Steve Yang <stevex.yang@intel.com>
Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
  • Loading branch information
Steve Yang authored and bluca committed Feb 4, 2021
1 parent 613019a commit 291718e
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/net/dpaa/dpaa_ethdev.c
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ dpaa_mtu_set(struct rte_eth_dev *dev, uint16_t mtu)
return -EINVAL;
}

if (frame_size > RTE_ETHER_MAX_LEN)
if (frame_size > DPAA_ETH_MAX_LEN)
dev->data->dev_conf.rxmode.offloads |=
DEV_RX_OFFLOAD_JUMBO_FRAME;
else
Expand Down
4 changes: 4 additions & 0 deletions drivers/net/dpaa/dpaa_ethdev.h
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,10 @@
#define VLAN_TAG_SIZE 4 /** < Vlan Header Length */
#endif

#define DPAA_ETH_MAX_LEN (RTE_ETHER_MTU + \
RTE_ETHER_HDR_LEN + RTE_ETHER_CRC_LEN + \
VLAN_TAG_SIZE)

/* PCD frame queues */
#define DPAA_DEFAULT_NUM_PCD_QUEUES 1
#define DPAA_VSP_PROFILE_MAX_NUM 8
Expand Down

0 comments on commit 291718e

Please sign in to comment.