Skip to content

Commit

Permalink
app/testpmd: remove useless check in TSO command
Browse files Browse the repository at this point in the history
[ upstream commit 773397f6f4b5e325e786835343bacbc454d1e5f0 ]

Testpmd has added the check of TSO offload capability of port, please see
the commit 3926dd2 ("app/testpmd: enforce offload capabilities check")

So the code following the check code memtioned above to display warning
when port doesn't support TSO offload doesn't access to forever.

Fixes: 3926dd2 ("app/testpmd: enforce offload capabilities check")

Signed-off-by: Huisong Li <lihuisong@huawei.com>
Acked-by: Ferruh Yigit <ferruh.yigit@amd.com>
  • Loading branch information
LiHuiSong1 authored and bluca committed Nov 15, 2023
1 parent 6486d9a commit 386140b
Showing 1 changed file with 0 additions and 12 deletions.
12 changes: 0 additions & 12 deletions app/test-pmd/cmdline.c
Original file line number Diff line number Diff line change
Expand Up @@ -4881,18 +4881,6 @@ cmd_tso_set_parsed(void *parsed_result,
ports[res->port_id].tso_segsz);
}
cmd_config_queue_tx_offloads(&ports[res->port_id]);

/* display warnings if configuration is not supported by the NIC */
ret = eth_dev_info_get_print_err(res->port_id, &dev_info);
if (ret != 0)
return;

if ((ports[res->port_id].tso_segsz != 0) &&
(dev_info.tx_offload_capa & DEV_TX_OFFLOAD_TCP_TSO) == 0) {
printf("Warning: TSO enabled but not "
"supported by port %d\n", res->port_id);
}

cmd_reconfig_device_queue(res->port_id, 1, 1);
}

Expand Down

0 comments on commit 386140b

Please sign in to comment.