Skip to content

Commit

Permalink
rawdev: fix calloc parameters
Browse files Browse the repository at this point in the history
[ upstream commit 37ff33833b6b8932bfbc8e149d386ef23ccdc54e ]

gcc [1] generates warning [2] about calloc usage, because calloc
parameter order is wrong, fixing it by replacing parameters.

[1]
gcc (GCC) 14.0.0 20240108 (experimental)

[2]
Compiling C object .../lib/librte_rawdev.a.p/rawdev_rte_rawdev.c.o
../lib/rawdev/rte_rawdev.c: In function ‘handle_dev_dump’:
../lib/rawdev/rte_rawdev.c:659:29:
  error: ‘calloc’ sizes specified with ‘sizeof’ in the earlier
  argument and not in the later argument
  [-Werror=calloc-transposed-args]
  659 |     buf = calloc(sizeof(char), RTE_TEL_MAX_SINGLE_STRING_LEN);
      |                         ^~~~

Fixes: e915d40 ("rawdev: support telemetry dump rawdev")

Signed-off-by: Ferruh Yigit <ferruh.yigit@amd.com>
Acked-by: Morten Brørup <mb@smartsharesystems.com>
Reviewed-by: Chengwen Feng <fengchengwen@huawei.com>
Reviewed-by: Hemant Agrawal <hemant.agrawal@nxp.com>
  • Loading branch information
ferruhy authored and bluca committed Mar 7, 2024
1 parent ba907df commit 477478f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/rawdev/rte_rawdev.c
Original file line number Diff line number Diff line change
Expand Up @@ -656,7 +656,7 @@ handle_dev_dump(const char *cmd __rte_unused,
if (!rte_rawdev_pmd_is_valid_dev(dev_id))
return -EINVAL;

buf = calloc(sizeof(char), RTE_TEL_MAX_SINGLE_STRING_LEN);
buf = calloc(RTE_TEL_MAX_SINGLE_STRING_LEN, sizeof(char));
if (buf == NULL)
return -ENOMEM;

Expand Down

0 comments on commit 477478f

Please sign in to comment.