Skip to content

Commit

Permalink
app/testpmd: add EEPROM command
Browse files Browse the repository at this point in the history 
Add module EEPROM/EEPROM dump command
   "show port <port_id> (module_eeprom|eeprom)"
Commands will dump the content of the EEPROM/module
EEPROM for the selected port.

Signed-off-by: David Liu <dliu@iol.unh.edu>
Reviewed-by: Phil Yang <phil.yang@arm.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
  • Loading branch information
David Liu authored and Ferruh Yigit committed Sep 30, 2020
1 parent bd6345e commit 6b67721
Show file tree
Hide file tree
Showing 4 changed files with 175 additions and 0 deletions.
49 changes: 49 additions & 0 deletions app/test-pmd/cmdline.c
View file
Expand Up @@ -166,6 +166,9 @@ static void cmd_help_long_parsed(void *parsed_result,
"show port (info|stats|summary|xstats|fdir|stat_qmap|dcb_tc|cap) (port_id|all)\n"
" Display information for port_id, or all.\n\n"

"show port port_id (module_eeprom|eeprom)\n"
" Display the module EEPROM or EEPROM information for port_id.\n\n"

"show port X rss reta (size) (mask0,mask1,...)\n"
" Display the rss redirection table entry indicated"
" by masks on port X. size is used to indicate the"
Expand Down Expand Up @@ -7705,6 +7708,51 @@ cmdline_parse_inst_t cmd_showdevice = {
NULL,
},
};

/* *** SHOW MODULE EEPROM/EEPROM port INFO *** */
struct cmd_showeeprom_result {
cmdline_fixed_string_t show;
cmdline_fixed_string_t port;
uint16_t portnum;
cmdline_fixed_string_t type;
};

static void cmd_showeeprom_parsed(void *parsed_result,
__rte_unused struct cmdline *cl,
__rte_unused void *data)
{
struct cmd_showeeprom_result *res = parsed_result;

if (!strcmp(res->type, "eeprom"))
port_eeprom_display(res->portnum);
else if (!strcmp(res->type, "module_eeprom"))
port_module_eeprom_display(res->portnum);
else
printf("Unknown argument\n");
}

cmdline_parse_token_string_t cmd_showeeprom_show =
TOKEN_STRING_INITIALIZER(struct cmd_showeeprom_result, show, "show");
cmdline_parse_token_string_t cmd_showeeprom_port =
TOKEN_STRING_INITIALIZER(struct cmd_showeeprom_result, port, "port");
cmdline_parse_token_num_t cmd_showeeprom_portnum =
TOKEN_NUM_INITIALIZER(struct cmd_showeeprom_result, portnum, UINT16);
cmdline_parse_token_string_t cmd_showeeprom_type =
TOKEN_STRING_INITIALIZER(struct cmd_showeeprom_result, type, "module_eeprom#eeprom");

cmdline_parse_inst_t cmd_showeeprom = {
.f = cmd_showeeprom_parsed,
.data = NULL,
.help_str = "show port <port_id> module_eeprom|eeprom",
.tokens = {
(void *)&cmd_showeeprom_show,
(void *)&cmd_showeeprom_port,
(void *)&cmd_showeeprom_portnum,
(void *)&cmd_showeeprom_type,
NULL,
},
};

/* *** SHOW QUEUE INFO *** */
struct cmd_showqueue_result {
cmdline_fixed_string_t show;
Expand Down Expand Up @@ -19507,6 +19555,7 @@ cmdline_parse_ctx_t main_ctx[] = {
(cmdline_parse_inst_t *)&cmd_load_from_file,
(cmdline_parse_inst_t *)&cmd_showport,
(cmdline_parse_inst_t *)&cmd_showqueue,
(cmdline_parse_inst_t *)&cmd_showeeprom,
(cmdline_parse_inst_t *)&cmd_showportall,
(cmdline_parse_inst_t *)&cmd_showdevice,
(cmdline_parse_inst_t *)&cmd_showcfg,
Expand Down
117 changes: 117 additions & 0 deletions app/test-pmd/config.c
View file
Expand Up @@ -49,6 +49,7 @@
#include <rte_pmd_bnxt.h>
#endif
#include <rte_gro.h>
#include <rte_hexdump.h>

#include "testpmd.h"

Expand Down Expand Up @@ -785,6 +786,122 @@ port_summary_display(portid_t port_id)
rte_eth_link_speed_to_str(link.link_speed));
}

void
port_eeprom_display(portid_t port_id)
{
struct rte_dev_eeprom_info einfo;
int ret;
if (port_id_is_invalid(port_id, ENABLED_WARN)) {
print_valid_ports();
return;
}

int len_eeprom = rte_eth_dev_get_eeprom_length(port_id);
if (len_eeprom < 0) {
switch (len_eeprom) {
case -ENODEV:
printf("port index %d invalid\n", port_id);
break;
case -ENOTSUP:
printf("operation not supported by device\n");
break;
case -EIO:
printf("device is removed\n");
break;
default:
printf("Unable to get EEPROM: %d\n", len_eeprom);
break;
}
return;
}

char buf[len_eeprom];
einfo.offset = 0;
einfo.length = len_eeprom;
einfo.data = buf;

ret = rte_eth_dev_get_eeprom(port_id, &einfo);
if (ret != 0) {
switch (ret) {
case -ENODEV:
printf("port index %d invalid\n", port_id);
break;
case -ENOTSUP:
printf("operation not supported by device\n");
break;
case -EIO:
printf("device is removed\n");
break;
default:
printf("Unable to get EEPROM: %d\n", ret);
break;
}
return;
}
rte_hexdump(stdout, "hexdump", einfo.data, einfo.length);
printf("Finish -- Port: %d EEPROM length: %d bytes\n", port_id, len_eeprom);
}

void
port_module_eeprom_display(portid_t port_id)
{
struct rte_eth_dev_module_info minfo;
struct rte_dev_eeprom_info einfo;
int ret;

if (port_id_is_invalid(port_id, ENABLED_WARN)) {
print_valid_ports();
return;
}


ret = rte_eth_dev_get_module_info(port_id, &minfo);
if (ret != 0) {
switch (ret) {
case -ENODEV:
printf("port index %d invalid\n", port_id);
break;
case -ENOTSUP:
printf("operation not supported by device\n");
break;
case -EIO:
printf("device is removed\n");
break;
default:
printf("Unable to get module EEPROM: %d\n", ret);
break;
}
return;
}

char buf[minfo.eeprom_len];
einfo.offset = 0;
einfo.length = minfo.eeprom_len;
einfo.data = buf;

ret = rte_eth_dev_get_module_eeprom(port_id, &einfo);
if (ret != 0) {
switch (ret) {
case -ENODEV:
printf("port index %d invalid\n", port_id);
break;
case -ENOTSUP:
printf("operation not supported by device\n");
break;
case -EIO:
printf("device is removed\n");
break;
default:
printf("Unable to get module EEPROM: %d\n", ret);
break;
}
return;
}

rte_hexdump(stdout, "hexdump", einfo.data, einfo.length);
printf("Finish -- Port: %d MODULE EEPROM length: %d bytes\n", port_id, einfo.length);
}

void
port_offload_cap_display(portid_t port_id)
{
Expand Down
2 changes: 2 additions & 0 deletions app/test-pmd/testpmd.h
View file
Expand Up @@ -721,6 +721,8 @@ void nic_stats_mapping_display(portid_t port_id);
void device_infos_display(const char *identifier);
void port_infos_display(portid_t port_id);
void port_summary_display(portid_t port_id);
void port_eeprom_display(portid_t port_id);
void port_module_eeprom_display(portid_t port_id);
void port_summary_header_display(void);
void port_offload_cap_display(portid_t port_id);
void rx_queue_infos_display(portid_t port_idi, uint16_t queue_id);
Expand Down
7 changes: 7 additions & 0 deletions doc/guides/testpmd_app_ug/testpmd_funcs.rst
View file
Expand Up @@ -218,6 +218,13 @@ For example:
nvgre
vxlan-gpe
show port (module_eeprom|eeprom)
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Display the EEPROM information of a port::

testpmd> show port (port_id) (module_eeprom|eeprom)

show port rss reta
~~~~~~~~~~~~~~~~~~

Expand Down

0 comments on commit 6b67721

Please sign in to comment.