Skip to content

Commit

Permalink
devtools: use libabigail rule for mlx glue drivers
Browse files Browse the repository at this point in the history
Convert the existing exception in the ABI script into a libabigail
suppression rule.

Note: file_name_regexp could be used to achieve the same with versions of
libabigail < 1.7 but soname_regexp has been preferred here since it is
already used with a recent change on common/mlx5.

While at it, fix indent from a recent change.

Signed-off-by: David Marchand <david.marchand@redhat.com>
Acked-by: Ray Kinsella <mdr@ashroe.eu>
  • Loading branch information
david-marchand authored and tmonjalo committed Mar 8, 2022
1 parent d58e0d5 commit 8fdcd51
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 9 deletions.
7 changes: 0 additions & 7 deletions devtools/check-abi.sh
Original file line number Diff line number Diff line change
Expand Up @@ -37,13 +37,6 @@ fi
error=
for dump in $(find $refdir -name "*.dump"); do
name=$(basename $dump)
# skip glue drivers, example librte_pmd_mlx5_glue.dump
# We can't rely on a suppression rule for now:
# https://sourceware.org/bugzilla/show_bug.cgi?id=25480
if grep -qE "\<soname='[^']*_glue\.so\.[^']*'" $dump; then
echo "Skipped glue library $name."
continue
fi
if grep -qE "\<librte_*.*_octeontx2" $dump; then
echo "Skipped removed driver $name."
continue
Expand Down
8 changes: 6 additions & 2 deletions devtools/libabigail.abignore
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,14 @@
[suppress_variable]
name_regexp = _pmd_info$

; Ignore changes on soname for mlx glue internal drivers
[suppress_file]
soname_regexp = ^librte_.*mlx.*glue\.

; Ignore fields inserted in place of reserved_opts of rte_security_ipsec_sa_options
[suppress_type]
name = rte_security_ipsec_sa_options
has_data_member_inserted_between = {offset_of(reserved_opts), end}
name = rte_security_ipsec_sa_options
has_data_member_inserted_between = {offset_of(reserved_opts), end}

; Ignore changes to rte_crypto_asym_op, asymmetric crypto API is experimental
[suppress_type]
Expand Down

0 comments on commit 8fdcd51

Please sign in to comment.