Skip to content

Commit

Permalink
net/mlx5: fix flow action destroy wrapper
Browse files Browse the repository at this point in the history
[ upstream commit 223f2c2 ]

Glue function destroy_flow_action() was wrapped by OS specific operation
mlx5_flow_os_destroy_flow_action(). It was skipped in file mlx5.c.

Fixes: b293fbf ("net/mlx5: add OS specific flow actions operations")

Signed-off-by: Ophir Munk <ophirmu@nvidia.com>
Acked-by: Matan Azrad <matan@nvidia.com>
  • Loading branch information
OphirMunk authored and bluca committed Feb 2, 2021
1 parent c9de97e commit a49c923
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 6 deletions.
7 changes: 4 additions & 3 deletions drivers/net/mlx5/mlx5.c
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@
#include "mlx5_autoconf.h"
#include "mlx5_mr.h"
#include "mlx5_flow.h"
#include "mlx5_flow_os.h"
#include "rte_pmd_mlx5.h"

/* Device parameter to enable RX completion queue compression. */
Expand Down Expand Up @@ -413,8 +414,8 @@ mlx5_flow_aso_age_mng_close(struct mlx5_dev_ctx_shared *sh)
for (j = 0; j < MLX5_COUNTERS_PER_POOL; ++j)
if (pool->actions[j].dr_action)
claim_zero
(mlx5_glue->destroy_flow_action
(pool->actions[j].dr_action));
(mlx5_flow_os_destroy_flow_action
(pool->actions[j].dr_action));
mlx5_free(pool);
}
mlx5_free(sh->aso_age_mng->pools);
Expand Down Expand Up @@ -521,7 +522,7 @@ mlx5_flow_counters_mng_close(struct mlx5_dev_ctx_shared *sh)

if (cnt->action)
claim_zero
(mlx5_glue->destroy_flow_action
(mlx5_flow_os_destroy_flow_action
(cnt->action));
if (fallback && MLX5_POOL_GET_CNT
(pool, j)->dcs_when_free)
Expand Down
6 changes: 3 additions & 3 deletions drivers/net/mlx5/mlx5_flow_dv.c
Original file line number Diff line number Diff line change
Expand Up @@ -11092,11 +11092,11 @@ flow_dv_sample_remove_cb(struct mlx5_cache_list *list __rte_unused,
struct mlx5_priv *priv = dev->data->dev_private;

if (cache_resource->verbs_action)
claim_zero(mlx5_glue->destroy_flow_action
claim_zero(mlx5_flow_os_destroy_flow_action
(cache_resource->verbs_action));
if (cache_resource->ft_type == MLX5DV_FLOW_TABLE_TYPE_FDB) {
if (cache_resource->default_miss)
claim_zero(mlx5_glue->destroy_flow_action
claim_zero(mlx5_flow_os_destroy_flow_action
(cache_resource->default_miss));
}
if (cache_resource->normal_path_tbl)
Expand Down Expand Up @@ -11149,7 +11149,7 @@ flow_dv_dest_array_remove_cb(struct mlx5_cache_list *list __rte_unused,

MLX5_ASSERT(cache_resource->action);
if (cache_resource->action)
claim_zero(mlx5_glue->destroy_flow_action
claim_zero(mlx5_flow_os_destroy_flow_action
(cache_resource->action));
for (; i < cache_resource->num_of_dest; i++)
flow_dv_sample_sub_actions_release(dev,
Expand Down

0 comments on commit a49c923

Please sign in to comment.