Skip to content

Commit

Permalink
net/bnxt: propagate FW command failure to application
Browse files Browse the repository at this point in the history
[ upstream commit 4297cad ]

In bnxt_reta_update_op() and bnxt_rss_hash_update_op(), driver does not
propagate the error back to the application when the fw command fails.

Fixes: 378ab64 ("net/bnxt: fix RSS RETA indirection table ops")
Fixes: fcc0aa1 ("net/bnxt: add RSS hash configuration")

Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>
Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
  • Loading branch information
Kalesh AP authored and bluca committed Feb 2, 2021
1 parent 6b544c7 commit b2a1b76
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions drivers/net/bnxt/bnxt_ethdev.c
Expand Up @@ -1843,8 +1843,8 @@ static int bnxt_reta_update_op(struct rte_eth_dev *eth_dev,
}
}

bnxt_hwrm_vnic_rss_cfg(bp, vnic);
return 0;
rc = bnxt_hwrm_vnic_rss_cfg(bp, vnic);
return rc;
}

static int bnxt_reta_query_op(struct rte_eth_dev *eth_dev,
Expand Down Expand Up @@ -1949,8 +1949,8 @@ static int bnxt_rss_hash_update_op(struct rte_eth_dev *eth_dev,
memcpy(vnic->rss_hash_key, rss_conf->rss_key, rss_conf->rss_key_len);

rss_config:
bnxt_hwrm_vnic_rss_cfg(bp, vnic);
return 0;
rc = bnxt_hwrm_vnic_rss_cfg(bp, vnic);
return rc;
}

static int bnxt_rss_hash_conf_get_op(struct rte_eth_dev *eth_dev,
Expand Down

0 comments on commit b2a1b76

Please sign in to comment.