Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sitesidebar shows tags from draft pages #977

Closed
Joduai opened this issue Mar 2, 2019 · 2 comments
Closed

sitesidebar shows tags from draft pages #977

Joduai opened this issue Mar 2, 2019 · 2 comments

Comments

@Joduai
Copy link

Joduai commented Mar 2, 2019

Using Theme::plugins('siteSidebar') to show plugins content in sidebar shows tag list containing those from draft pages. Checked twice to be sure.

After searching through issues I found that this bug should be fixed in v2.0 #274 but it seems to be a regress.

Tags plugin grabs tags from tagsDB, which contains all pages urls and tags only.
Shouldn't tagsDB contain also page type to filter out unneeded tags?
Also tags from static pages are in, but imo they shouldn't.

@dignajar
Copy link
Member

dignajar commented Mar 7, 2019

I fixed the bug and created an array with the type of pages allowed in the database, by default the types are published, sticky and static.

185ae09

@Joduai
Copy link
Author

Joduai commented Mar 7, 2019

Checked with latest updates and works as supposed.

@Joduai Joduai closed this as completed Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants