New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to include version for Bludit 3 #8

Merged
merged 4 commits into from Oct 15, 2018

Conversation

2 participants
@BlakesHeaven
Contributor

BlakesHeaven commented Oct 6, 2018

I've added a new folder in my repository for a Bludit 3 compatible version.
Please keep it pointing to Master.zip as I keep a complete plugin version in separate folders.
BTW - I have had to strip back functionality by removing the "Admin Stuff" section restriction to only show content to Admin/Editors. This is because Bludit 3 can't surface the logged-in user role to the plugin any more!

BlakesHeaven added some commits Oct 6, 2018

Update to include version for Bludit 3
I've added a new folder in my repository for a Bludit 3 compatible version.
Please keep it pointing toMaster.zip as I keep a complete plugin version in separate folders.
BTW - I have had to strip back functionality by removing the "Admin Stuff" section restriction to only show content to Admin/Editors. This is because Bludit 3 can't surface the logged-in user role to the plugin any more!
"version": "2.3",
"release_date": "2018-05-06",
"version": "2.3, 3.0",
"release_date": "2018-010-06",

This comment has been minimized.

@dignajar

dignajar Oct 9, 2018

Member

Check the date.

"license": "MIT",
"price_usd": "0",
"download_url": "https://github.com/BlakesHeaven/Auto-Archive-Menu-Plus-More/archive/v2.3.x.zip",
"download_url": "https://github.com/BlakesHeaven/Auto-Archive-Menu-Plus-More/archive/master.zip",

This comment has been minimized.

@dignajar

dignajar Oct 9, 2018

Member

This version is for Bludit v3? the field name is download_url_v3

@dignajar

This comment has been minimized.

Member

dignajar commented Oct 9, 2018

Hi,
is going to be better for you provide a repository for each version because is easier to create a release, or at least for the new major version of Bludit (Bludit v3.x).
With the release, you can have a control of the versions of the plugin.
I leave a few comments in the code.
Regards

"license": "MIT",
"price_usd": "0",
"download_url": "https://github.com/BlakesHeaven/Auto-Archive-Menu-Plus-More/archive/v2.3.x.zip",
"download_url": "https://github.com/BlakesHeaven/Auto-Archive-Menu-Plus-More/archive/v3.0.0.zip",

This comment has been minimized.

@dignajar

dignajar Oct 15, 2018

Member

the field for Bludit v3.x is download_url_v3

Changed field name.
 from download_url to download_url_v3

@dignajar dignajar merged commit cfe4bd7 into bludit:master Oct 15, 2018

@BlakesHeaven BlakesHeaven deleted the BlakesHeaven:patch-1 branch Oct 15, 2018

@BlakesHeaven

This comment has been minimized.

Contributor

BlakesHeaven commented Oct 15, 2018

Thanks Dignajar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment