Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to include version for Bludit 3 #8

Merged
merged 4 commits into from Oct 15, 2018
Merged

Update to include version for Bludit 3 #8

merged 4 commits into from Oct 15, 2018

Conversation

BlakesHeaven
Copy link
Contributor

@BlakesHeaven BlakesHeaven commented Oct 6, 2018

I've added a new folder in my repository for a Bludit 3 compatible version.
Please keep it pointing to Master.zip as I keep a complete plugin version in separate folders.
BTW - I have had to strip back functionality by removing the "Admin Stuff" section restriction to only show content to Admin/Editors. This is because Bludit 3 can't surface the logged-in user role to the plugin any more!

I've added a new folder in my repository for a Bludit 3 compatible version.
Please keep it pointing toMaster.zip as I keep a complete plugin version in separate folders.
BTW - I have had to strip back functionality by removing the "Admin Stuff" section restriction to only show content to Admin/Editors. This is because Bludit 3 can't surface the logged-in user role to the plugin any more!
"version": "2.3",
"release_date": "2018-05-06",
"version": "2.3, 3.0",
"release_date": "2018-010-06",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the date.

"license": "MIT",
"price_usd": "0",
"download_url": "https://github.com/BlakesHeaven/Auto-Archive-Menu-Plus-More/archive/v2.3.x.zip",
"download_url": "https://github.com/BlakesHeaven/Auto-Archive-Menu-Plus-More/archive/master.zip",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This version is for Bludit v3? the field name is download_url_v3

@dignajar
Copy link
Member

dignajar commented Oct 9, 2018

Hi,
is going to be better for you provide a repository for each version because is easier to create a release, or at least for the new major version of Bludit (Bludit v3.x).
With the release, you can have a control of the versions of the plugin.
I leave a few comments in the code.
Regards

"license": "MIT",
"price_usd": "0",
"download_url": "https://github.com/BlakesHeaven/Auto-Archive-Menu-Plus-More/archive/v2.3.x.zip",
"download_url": "https://github.com/BlakesHeaven/Auto-Archive-Menu-Plus-More/archive/v3.0.0.zip",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the field for Bludit v3.x is download_url_v3

 from download_url to download_url_v3
@dignajar dignajar merged commit cfe4bd7 into bludit:master Oct 15, 2018
@BlakesHeaven BlakesHeaven deleted the patch-1 branch October 15, 2018 13:20
@BlakesHeaven
Copy link
Contributor Author

Thanks Dignajar.

clickwork-git pushed a commit that referenced this pull request Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants