Skip to content
This repository has been archived by the owner on Dec 1, 2021. It is now read-only.

One operator has at most one output #1113

Merged
merged 2 commits into from Jul 3, 2020

Conversation

primenumber
Copy link
Contributor

What this patch does to fix the issue.

In blueoil/converter, some operators has multiple outputs, but current code base cannot hold multiple outputs correctly.
This PR divides Split operator into Slice operators, Unique operator into UniqueValue and UniqueIndex operators.

Link to any relevant issues or pull requests.

Workaround solution for #1061 (see #1061 (comment) ).

@primenumber primenumber requested a review from tkng July 2, 2020 03:31
@primenumber primenumber self-assigned this Jul 2, 2020
@blueoil-butler blueoil-butler bot added the CI: auto-run Run CI automatically label Jul 2, 2020
@bo-code-review-bot
Copy link

This PR needs Approvals as follows.

  • Ownership Approval for / from iizukak, tkng, ruimashita
  • Readability Approval for Python from tkng, tsawada, tfujiwar

Please choose reviewers and requet reviews!

Click to see how to approve each reviews

You can approve this PR by triggered comments as follows.

  • Approve all reviews requested to you (readability and ownership) and LGTM review
    Approval, LGTM

  • Approve all ownership reviews
    Ownership Approval or OA

  • Approve all readability reviews
    Readability Approval or RA

  • Approve specified review targets

    • Example of Ownership Reviewer of /: Ownership Approval for / or OA for /
    • Example of Readability Reviewer of Python: Readability Approval for Python or RA for Python
  • Approve LGTM review
    LGTM

See all trigger comments

Please replace [Target] to review target

  • Ownership Approval
    • Ownership Approval for [Target]
    • OA for [Target]
    • Ownership Approval
    • OA
    • Approval
  • Readability Approval
    • Readability Approval for [Target]
    • RA for [Target]
    • [Target] Readability Approval
    • [Target] RA
    • Readability Approval
    • RA
    • Approval
  • LGTM
    • LGTM
    • lgtm

Copy link
Contributor

@tkng tkng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than a very small change, LGTM.

blueoil/converter/core/operators.py Outdated Show resolved Hide resolved
@tkng
Copy link
Contributor

tkng commented Jul 3, 2020

Thanks!
OA
RA

@tkng
Copy link
Contributor

tkng commented Jul 3, 2020

/ready

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented Jul 3, 2020

⏳Merge job is queued...

@bo-mergebot bo-mergebot bot merged commit 6e151f2 into blue-oil:master Jul 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI: auto-run Run CI automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants