Skip to content
This repository has been archived by the owner on Dec 1, 2021. It is now read-only.

fix : Change time.clock to time.perf_counter #1191

Merged
merged 2 commits into from Sep 4, 2020

Conversation

lm-kasuga
Copy link
Contributor

No description provided.

@lm-kasuga lm-kasuga requested a review from iizukak August 31, 2020 04:20
@blueoil-butler blueoil-butler bot added the CI: auto-run Run CI automatically label Aug 31, 2020
@bo-code-review-bot
Copy link

This PR needs Approvals as follows.

  • Ownership Approval for / from iizukak, tkng, ruimashita
  • Readability Approval for Python from tkng, tsawada, tfujiwar, a-hanamoto

Please choose reviewers and requet reviews!

Click to see how to approve each reviews

You can approve this PR by triggered comments as follows.

  • Approve all reviews requested to you (readability and ownership) and LGTM review
    Approval, LGTM

  • Approve all ownership reviews
    Ownership Approval or OA

  • Approve all readability reviews
    Readability Approval or RA

  • Approve specified review targets

    • Example of Ownership Reviewer of /: Ownership Approval for / or OA for /
    • Example of Readability Reviewer of Python: Readability Approval for Python or RA for Python
  • Approve LGTM review
    LGTM

See all trigger comments

Please replace [Target] to review target

  • Ownership Approval
    • Ownership Approval for [Target]
    • OA for [Target]
    • Ownership Approval
    • OA
    • Approval
  • Readability Approval
    • Readability Approval for [Target]
    • RA for [Target]
    • [Target] Readability Approval
    • [Target] RA
    • Readability Approval
    • RA
    • Approval
  • LGTM
    • LGTM
    • lgtm

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@lm-kasuga lm-kasuga linked an issue Aug 31, 2020 that may be closed by this pull request
Copy link
Member

@iizukak iizukak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OA

@iizukak iizukak added the CI: test-all Run all tests once label Aug 31, 2020
@blueoil-butler blueoil-butler bot removed the CI: test-all Run all tests once label Aug 31, 2020
@lm-kasuga lm-kasuga added the CI: test-all Run all tests once label Sep 1, 2020
@blueoil-butler blueoil-butler bot removed the CI: test-all Run all tests once label Sep 1, 2020
@lm-kasuga lm-kasuga added the CI: test-dlk Run dlk test once label Sep 1, 2020
@blueoil-butler blueoil-butler bot removed the CI: test-dlk Run dlk test once label Sep 1, 2020
@lm-kasuga lm-kasuga added the CI: test-dlk Run dlk test once label Sep 2, 2020
@blueoil-butler blueoil-butler bot removed the CI: test-dlk Run dlk test once label Sep 2, 2020
Copy link
Contributor

@tfujiwar tfujiwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RA
nice refactoring 👍

@iizukak
Copy link
Member

iizukak commented Sep 4, 2020

/ready

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented Sep 4, 2020

⏳Merge job is queued...

@bo-mergebot bo-mergebot bot merged commit 034ccfb into blue-oil:master Sep 4, 2020
@lm-kasuga lm-kasuga deleted the fix-time-clock branch September 23, 2020 04:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI: auto-run Run CI automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

time.clock will be removed in Python 3.8
4 participants