-
Notifications
You must be signed in to change notification settings - Fork 85
Add bug-fixed version of quantized convolution IP with kn2row and tiling #130
Conversation
…ented as a memory
…function is constant
Can one of the admins verify this patch? |
@tkclimb nice! 👍 |
…ented as a memory
…function is constant
@n-nez and me tried your branch with the correct .rbf and preloader manually. It works fine. Seems that the testing code still using the old .rbf and preloader. Maybe |
…ueoil into add_qconv_kn2row_tiling
run dlk test |
@n-nez @antonionevado @lm-lily |
@ruimashita Already approved it. There are lots of unused code / unrelated changes under For the meaningful part of the code, everything is ok. 🙂 |
@n-nez
But it is nice, no problem, Thanks 👍👍👍 |
@ruimashita Yep, I know, I saw them too. 🙂 |
Add bug-fixed version of quantized convolution IP with kn2row and tiling
Overview
This request mainly focuses on adding new quantized convolution IP called qconv_kn2row_tiling.
During my development, I've used linter in my environment (clang-format), so this seems to have many modified files that are not inherently important.
Also this request contains much context and some analysis I need to explain, so I described them in the following doc. Please quickly scan it, then check the modification if you'd like.
https://docs.google.com/document/d/1_WmWuJ2cRZ5ZOC3TBWMi220ji5kfN67jerBhDBXzTKg/edit?usp=sharing