Skip to content
This repository has been archived by the owner on Dec 1, 2021. It is now read-only.

Rename view.shape and view.shape_list #594

Merged
merged 2 commits into from Nov 7, 2019

Conversation

primenumber
Copy link
Contributor

fix #468 .

These functions are used in *.tpl.cpp / *.tpl.h files and name of the functions didn't match for usage.

Motivation and Context

Description

  • shape -> size_in_words_as_cpp
  • shape_list -> shape_as_cpp

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature / Optimization (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@primenumber primenumber self-assigned this Nov 6, 2019
@blueoil-butler blueoil-butler bot added the CI: auto-run Run CI automatically label Nov 6, 2019
@tkng tkng self-requested a review November 6, 2019 17:28
Copy link
Contributor

@tkng tkng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

@tkng tkng merged commit 1cb88bd into blue-oil:master Nov 7, 2019
@primenumber primenumber deleted the rename/view-funcs branch November 7, 2019 03:52
@iizukak iizukak added this to the v0.14.0 milestone Nov 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI: auto-run Run CI automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

shape method in the View class should be renamed
3 participants