Skip to content
This repository has been archived by the owner on Dec 1, 2021. It is now read-only.

Simple refactoring #76

Merged
merged 19 commits into from Jan 28, 2019
Merged

Simple refactoring #76

merged 19 commits into from Jan 28, 2019

Conversation

lm-konda
Copy link
Contributor

Motivation and Context

refactoring and understand code overview.

Description

add specifier to float constant (may reduce redundant type conversion).
remove unused variable.
remove redundant static memory allocation.

How has this been tested?

Validation with 2 patterns.
 Classification (LmnetV1Quantize / Caltech101 / epoch=2, other settings=default / DE10-nano)
 Object Detection (LMFYoloQuantize / OpenImagesV4 / epoch=2, other settings=default / DE10-nano)
run blueoil_test.sh

Screenshots (if appropriate):

no screenshot

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature / Optimization (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Copy link
Contributor

@ruimashita ruimashita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruimashita
Copy link
Contributor

@lm-konda
Notice: Need to resolve conflict 👍

@ruimashita ruimashita merged commit 0462274 into blue-oil:master Jan 28, 2019
@ruimashita
Copy link
Contributor

@lm-konda Thanks 😄

@iizukak iizukak added this to the v0.3 milestone Feb 6, 2019
ruimashita added a commit that referenced this pull request Jun 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants