This repository has been archived by the owner on Dec 1, 2021. It is now read-only.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruimashita
approved these changes
Jan 18, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
lm-konda
force-pushed
the
refactoring_only
branch
from
January 24, 2019 05:31
8d60316
to
7c40804
Compare
@lm-konda |
@lm-konda Thanks 😄 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
refactoring and understand code overview.
Description
add specifier to float constant (may reduce redundant type conversion).
remove unused variable.
remove redundant static memory allocation.
How has this been tested?
Validation with 2 patterns.
Classification (LmnetV1Quantize / Caltech101 / epoch=2, other settings=default / DE10-nano)
Object Detection (LMFYoloQuantize / OpenImagesV4 / epoch=2, other settings=default / DE10-nano)
run blueoil_test.sh
Screenshots (if appropriate):
no screenshot
Types of changes