Skip to content
This repository has been archived by the owner on Dec 1, 2021. It is now read-only.

Move lmnet/lmnet/utils utils to blueoil/utils #826

Merged
merged 6 commits into from Feb 12, 2020

Conversation

iizukak
Copy link
Member

@iizukak iizukak commented Feb 12, 2020

This PR is a part of #796
I moved lmnet/lmnet/utils to blueoil/utils

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature / Optimization (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@blueoil-butler blueoil-butler bot added the CI: auto-run Run CI automatically label Feb 12, 2020
@bo-code-review-bot
Copy link

This PR needs Approvals as follows.

  • Readability Approval for Python from tkng, tsawada

Please choose reviewers and requet reviews!

Click to see how to approve each reviews

You can approve this PR by triggered comments as follows.

  • Approve all reviews requested to you (readability and ownership) and LGTM review
    Approval, LGTM

  • Approve all ownership reviews
    Ownership Approval or OA

  • Approve all readability reviews
    Readability Approval or RA

  • Approve specified review targets

    • Example of Ownership Reviewer of /: Ownership Approval for / or OA for /
    • Example of Readability Reviewer of Python: Readability Approval for Python or RA for Python
  • Approve LGTM review
    LGTM

See all trigger comments

Please replace [Target] to review target

  • Ownership Approval
    • Ownership Approval for [Target]
    • OA for [Target]
    • Ownership Approval
    • OA
    • Approval
  • Readability Approval
    • Readability Approval for [Target]
    • RA for [Target]
    • [Target] Readability Approval
    • [Target] RA
    • Readability Approval
    • RA
    • Approval
  • LGTM
    • LGTM
    • lgtm

@iizukak iizukak changed the title Move lmnet utils to bluoil Move lmnet/lmnet/utils utils to blueoil/utils Feb 12, 2020
@iizukak
Copy link
Member Author

iizukak commented Feb 12, 2020

@odoku @tfujiwar @suttang Please re-review this PR 🙇 🙇 🙇

Copy link
Contributor

@odoku odoku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

@iizukak iizukak requested a review from tsawada February 12, 2020 07:28
Copy link
Contributor

@tsawada tsawada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Readability Approval

@iizukak
Copy link
Member Author

iizukak commented Feb 12, 2020

/ready

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented Feb 12, 2020

⏳Merge job is queued...

@bo-mergebot bo-mergebot bot merged commit e9794e4 into blue-oil:master Feb 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI: auto-run Run CI automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants