Skip to content
This repository has been archived by the owner on Dec 1, 2021. It is now read-only.

Fixed pep8 errors "F405" in converter #981

Merged
merged 1 commit into from Apr 13, 2020
Merged

Fixed pep8 errors "F405" in converter #981

merged 1 commit into from Apr 13, 2020

Conversation

tfujiwar
Copy link
Contributor

@tfujiwar tfujiwar commented Apr 13, 2020

What this patch does to fix the issue.

Many pep8 errors occurred because of star imports.
This PR reduces pep8 errors in converter from 432 to 96.

F405 'List' may be undefined, or defined from star imports: .data_types

Link to any relevant issues or pull requests.

#979

@blueoil-butler blueoil-butler bot added the CI: auto-run Run CI automatically label Apr 13, 2020
@bo-code-review-bot
Copy link

This PR needs Approvals as follows.

  • Ownership Approval for / from iizukak, tkng, ruimashita

Please choose reviewers and requet reviews!

Click to see how to approve each reviews

You can approve this PR by triggered comments as follows.

  • Approve all reviews requested to you (readability and ownership) and LGTM review
    Approval, LGTM

  • Approve all ownership reviews
    Ownership Approval or OA

  • Approve all readability reviews
    Readability Approval or RA

  • Approve specified review targets

    • Example of Ownership Reviewer of /: Ownership Approval for / or OA for /
    • Example of Readability Reviewer of Python: Readability Approval for Python or RA for Python
  • Approve LGTM review
    LGTM

See all trigger comments

Please replace [Target] to review target

  • Ownership Approval
    • Ownership Approval for [Target]
    • OA for [Target]
    • Ownership Approval
    • OA
    • Approval
  • Readability Approval
    • Readability Approval for [Target]
    • RA for [Target]
    • [Target] Readability Approval
    • [Target] RA
    • Readability Approval
    • RA
    • Approval
  • LGTM
    • LGTM
    • lgtm

@tfujiwar tfujiwar requested a review from iizukak April 13, 2020 10:08
Copy link
Member

@iizukak iizukak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OA

@tfujiwar
Copy link
Contributor Author

/ready

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented Apr 13, 2020

⏳Merge job is queued...

@bo-mergebot bo-mergebot bot merged commit cef8fb6 into blue-oil:master Apr 13, 2020
@tfujiwar tfujiwar deleted the fix-pep8-F405 branch April 13, 2020 14:19
oatawa1 pushed a commit to oatawa1/blueoil that referenced this pull request Apr 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI: auto-run Run CI automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants