fix: Adhere to case-insensivity in 'matched_by_list' #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will lead to e.g. blacklisting 'cython' and 'Cython' being the same thing.
matthias-bach-by
approved these changes
Sep 9, 2020
| @@ -61,7 +61,7 @@ def matched_by_list(package, version, requirements): | |||
| version = pkg_resources.safe_version('{}'.format(version)) | |||
| package = pkg_resources.safe_name(package) | |||
| matches = ( | |||
| package == requirement.project_name and version in requirement | |||
| package.lower() == requirement.key and version in requirement | |||
There was a problem hiding this comment.
Just wondering. Will key always be in lower case or should that also be explicitly lower-cased?
There was a problem hiding this comment.
According to https://setuptools.readthedocs.io/en/latest/pkg_resources.html:
key
dist.key is short for dist.project_name.lower(). It’s used for case-insensitive comparison and indexing of distributions by project name.
|
LGTM. I cannot (easily) approve button though - my new Github BY account is not a contributor yet :) |
|
@patrick-ringl-by : Do you feel comfortable packaging up a release or should I try to squeeze this in some time today? Required for release would be:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will lead to e.g. blacklisting 'cython' and 'Cython' being the same thing.