Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debugging the build #164

Merged
merged 2 commits into from
Nov 5, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ jobs:
python -m pip install --no-deps -e .
python -m pip install coveralls
python -m pip freeze
python -m pip --version
python -c 'import setuptools; print(f"setuptools=={setuptools.__version__}")'
- name: Test with pytest
run: |
pytest
Expand Down
11 changes: 11 additions & 0 deletions CHANGELOG.rst
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,17 @@ Changelog

This lists the most important changes for each release.


Version 5.1.0 — Unreleased
==========================

Added
-----

* Provide compatibility with pip 21.3 and above which drops the `--build-directory` option.
Pip has been using a temporary directory for builds since version 1.2 so manual handling of this directory should not be necessary anymore.


Version 5.0.1 – 2020-09-09
==========================

Expand Down
3 changes: 0 additions & 3 deletions devpi_builder/wheeler.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ class Builder(object):
def __enter__(self):
self.scratch_dir = tempfile.mkdtemp()
self.wheelhouse = path.join(self.scratch_dir, 'wheels')
self.builddir = path.join(self.scratch_dir, 'build')
return lambda *args: self.build(*args)

def __exit__(self, exc_type, exc_val, exc_tb):
Expand Down Expand Up @@ -78,12 +77,10 @@ def build(self, package, version):
:param version: The version to generate the wheel for
:return: The path of the build wheel. Valid until the context is exited.
"""
shutil.rmtree(self.builddir, ignore_errors=True)
try:
subprocess.check_output([
'pip', 'wheel',
'--wheel-dir=' + self.wheelhouse,
'--build=' + self.builddir,
'{}=={}'.format(package, version)
], stderr=subprocess.STDOUT)
return self._find_wheel(package, version)
Expand Down