Improve compatibility with Devpi 5.x #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Devpi 5.x seems to get stuck when processing of events is active during state import. As disabling it provides a faster import and thus a faster availability of the server, which will then process those events after having started up, disabling event processing during import seems a sane default.
theMarix
force-pushed
the
devpi-5
branch
3 times, most recently
from
2014fcf
to
459695e
Compare
|
Finally managed to fix all those Python version compatibility issues. So this should be good to review now. |
StephanErb
reviewed
Aug 6, 2019
| @@ -44,7 +44,7 @@ def TestServer(users={}, indices={}, config={}, fail_on_output=['Traceback']): | |||
|
|
|||
| def import_state(serverdir, importdir): | |||
| devpi_server_command(serverdir=serverdir, init=None) | |||
| devpi_server_command(serverdir=serverdir, **{'import': importdir}) | |||
| devpi_server_command(serverdir=serverdir, **{'import': importdir, 'no-events': None}) | |||
There was a problem hiding this comment.
What part of the Devpi 5.x release is this related to? 🤔
There was a problem hiding this comment.
Ah. Finally saw the commit message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow to fix the currently broken master of the Devpi acceptance tests.